feat(android): bump androidx.activity default version from v1.8.2 to v1.9.3 #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangJonghun
requested review from
seyedmostafahasani,
freeboub and
KrzysztofMoch
freeboub
approved these changes
Nov 29, 2024
seyedmostafahasani
approved these changes
Nov 30, 2024
|
Do we need to bump min kotlin version for it? |
I think the idea is to merge it first and exploit it in the pip PR. |
|
Okay then - I want to merge/release PiP PR next week (2.12-8.12), we already have some positive feedback from community so I think it should be okay |
KrzysztofMoch
approved these changes
Dec 1, 2024
|
Yep it works for me ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
androidx.activity:activity-ktxversion from v1.8.2 to v1.9.3Motivation
onUserLeaveHintcan be used without an implementation of MainActivity. This feature makes it possible to remove some of tricky implementation within PR feat: implement enterPictureInPictureOnLeave prop for both platform(Android, iOS) #3385 .Changes
OnBackPressedCallbackofFullScreenPlayerView.kt, and this feature works properly. However, users who have been forcing legacy version instead of the default may have issues.Test plan