fix: validate Stellar address in account endpoints#376
Merged
thecodedcoder merged 1 commit intoThinkLikeAFounder:mainfrom Mar 30, 2026
Merged
Conversation
|
@0xDeon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Added validateAddress middleware using Keypair.fromPublicKey - Applied to /:address and /:address/transactions routes - Prevents invalid inputs from reaching Horizon SDK - Normalized limit parsing with Number.isNaN check - Updated test to use a valid Stellar public key Closes ThinkLikeAFounder#337
0xDeon
force-pushed
the
fix/address-validation-routes
branch
from
2b68270 to
dabf485
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #337
Changes
validateAddressmiddleware usingKeypair.fromPublicKeyfrom@stellar/stellar-sdkGET /account/:addressandGET /account/:address/transactionsroutes400before reaching Horizon SDKlimitquery param parsing withNumber.isNaNcheck to avoidNaNsilently passing