FIX: [Makefile] command is echoed out to stdout #14
Conversation
There was a problem hiding this comment.
Actually, Nitish, could you slightly change your commit with a commit message that describes the action being taken by the commit. Something like "[JSON] Suppress command echo to stdout", and then in the commit message, could you state the current situation, why it's a problem, and what you did to fix it?
snapdgn
force-pushed
the
JSON
branch
4 times, most recently
from
759bc97
to
ad0ebb8
Compare
|
@ThinkOpenly , Sorry, I forgot to ping you. Can this be closed now? |
I'm being pedantic, but let's follow "generally accepted practices" for some important open source projects and limit the width of the commit message to less than 80 characters. Could you break the final line of your commit message before 80 characters? Thanks! |
Currently, when executing `make json`, the command itself is echoed, causing issues with the JSON representation. This PR Suppress this echoing, ensuring a proper JSON output without the need for any manual editing later on.
Sorry, I had wrapping turned on in my vim configs at 80 chars, I don't know why this happened, maybe a misconfiguration. |
When running
make json, it outputs a validjsonwithout any debug outputs , EXCEPT it echoes out the command too, thus messing up the json representation.Refer the Screenshot below for clarity.
This PR fixes it so that no hand-editing is required.
P.S - This was such a small change, that I didn't think creating a new branch was necessary. Let me know if I should do that in future.
Thanks