Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check table exists in current search path #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/__tests__/fixtures/multiple-schemas-2/1_another.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
CREATE TABLE another (
id integer
);
3 changes: 3 additions & 0 deletions src/__tests__/fixtures/multiple-schemas/1_success.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
CREATE TABLE success (
id integer
);
40 changes: 40 additions & 0 deletions src/__tests__/migrate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,35 @@ test("concurrent migrations - index concurrently", async (t) => {
t.truthy(exists)
})

test("multiple schemas", async (t) => {
const databaseName = "migration-test-multiple-schemas"
const dbConfig = {
database: databaseName,
user: "postgres",
password: PASSWORD,
host: "localhost",
port,
}

await createDb(databaseName, dbConfig)
const client = new pg.Client(dbConfig)
await client.connect()

await createSchema(client, "schema_1")
await useSchema(client, "schema_1")
await migrate({client}, "src/__tests__/fixtures/multiple-schemas")
const firstMigrationSucceeded = await doesTableExist(dbConfig, "success")
t.truthy(firstMigrationSucceeded)

await createSchema(client, "schema_2")
await useSchema(client, "schema_2")
await migrate({client}, "src/__tests__/fixtures/multiple-schemas-2")
const secondMigrationSucceeded = await doesTableExist(dbConfig, "another")
t.truthy(secondMigrationSucceeded)

await client.end()
})

// can't test with unconnected client because `pg` just hangs on the first query...
test("with connected client", async (t) => {
const databaseName = "migration-test-with-connected-client"
Expand Down Expand Up @@ -720,3 +749,14 @@ function doesTableExist(dbConfig: pg.ClientConfig, tableName: string) {
}
})
}

async function createSchema(
client: pg.Client,
schemaName: string,
): Promise<void> {
await client.query(`CREATE SCHEMA ${schemaName};`)
}

async function useSchema(client: pg.Client, schemaName: string): Promise<void> {
await client.query(`SET search_path TO ${schemaName};`)
}
15 changes: 7 additions & 8 deletions src/migrate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -200,14 +200,13 @@ function logResult(completedMigrations: Array<Migration>, log: Logger) {
}
}

/** Check whether table exists in postgres - http://stackoverflow.com/a/24089729 */
/** Check whether table exists in postgres in the current search path
* http://stackoverflow.com/a/24089729
* https://dba.stackexchange.com/a/86098
*/
async function doesTableExist(client: BasicPgClient, tableName: string) {
const result = await client.query(SQL`SELECT EXISTS (
SELECT 1
FROM pg_catalog.pg_class c
WHERE c.relname = ${tableName}
AND c.relkind = 'r'
);`)

const result = await client.query(
SQL`SELECT to_regclass(${tableName}) is not NULL as exists;`,
)
return result.rows.length > 0 && result.rows[0].exists
}