feat: Handle flat elevation profiles #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Built upon idea of @JulesL2 to handle tracks with flat elevation profiles.
Instead of modifying at drawing time, I update the bot_ratio and ele_ratio accordingly right before downloading the background data. That way we end up with a perflectly centered background, instead of leaving some kind of empty space above the flattened elevation profile.
Corresponding Github Issues / Pull Requests
PR #97
Issue #93
Proof of Functionality
Provide evidence that the changes work as intended. Include screenshots, logs, or other relevant output.
Left: Current main branch. The elevation profile is excessively large compared to the low total uphill
Right: Proposed solution. The background has been slightly shifted towards the bottom
Warning