fix(sqs): UUID lost via marshalling #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The watermill message UUID was lost during publishing & subscribing to the message, because sqs.Message's `MessageId` should signify the Amazon message ID, not the watermill message UUID. Use the metadata to store the UUID under the key `_watermill_message_uuid`. Minor simplifications/pre-allocations of data for performance.
llulioscesar
approved these changes
Feb 1, 2024
JAORMX
approved these changes
Mar 20, 2024
I think this is no longer happening, it was fixed on PR #14
Adding the length on the attributes map will be probably an improvement, maybe we can add this in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The watermill message UUID was lost during publishing & subscribing to the message, because sqs.Message's
MessageIdshould signify the Amazon message ID, not the watermill message UUID.Use the metadata to store the UUID under the key
_watermill_message_uuid.Minor simplifications/pre-allocations of data for performance.