Fix #275 and add gochannel concurreny control #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m110
reviewed
Jan 21, 2023
| @@ -342,12 +346,13 @@ func (s *subscriber) Close() { | |||
| } | |||
|
|
|||
| func (s *subscriber) sendMessageToSubscriber(msg *message.Message, logFields watermill.LogFields) { | |||
| s.sending.Lock() | |||
There was a problem hiding this comment.
We might still need the lock to avoid race conditions with Close.
m110
reviewed
Jan 21, 2023
| defer s.sending.Unlock() | ||
| s.sendingChannel <- struct{}{} | ||
| defer func() { | ||
| <-s.sendingChannel |
There was a problem hiding this comment.
sendMessageToSubscriber is also called to deliver persisted messages to newly joining subscribers. I'm not sure if this will behave as expected in this case. Can we have some tests to cover it?
There was a problem hiding this comment.
Sure, I'll check again and add some tests for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the sending lock, and replaced it with a channel to control concurrency.