#8818 fix default checkbox checked value issue on anon config modal #8825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed: webplusai has already signed the Contributor License Agreement (see contributing.md) |
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Leilei332
reviewed
Dec 17, 2024
| @@ -9,12 +9,22 @@ class: mws-modal | |||
| <form class="mws-anon-config-form" method="POST" action="/admin/post-anon-config"> | |||
| <div class="mws-modal-section"> | |||
| <$set name="isChecked" value={{{ [[$:/config/MultiWikiServer/AllowAnonymousReads]get[text]] }}}> | |||
| <input type="checkbox" name="allowReads" checked=<<isChecked>>/> Allow anonymous reads | |||
There was a problem hiding this comment.
Actually I wonder why the checkbox widget cannot be used here.
There was a problem hiding this comment.
The approach here is to use wikitext to generate a static HTML form. The checkbox widget doesn't work within a static rendering because it needs the TW runtime.
|
Thanks @webplusai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.