Skip to content

Examples of pull requests which may need further discussion

pmario edited this page Jul 2, 2011 · 2 revisions

There are certain situations where a pull request will require further discussion before being merged into the TiddlyWiki code base.

Some examples of these situations might be one of the following

  • impacts on backwards compatibility
  • impacts on existing tests (all unit tests should pass after a merge)
  • provides new functionality that is too specific to a certain type of TiddlyWiki user
  • code results in a visible change to the appearance of TiddlyWiki
  • creates discussion around the naming of certain parameters
  • the TiddlyWiki code is being stabilised in time for a new release and is not accepting new features