Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

109 update the database when an event occurs on the fs #119

Merged
merged 19 commits into from
Feb 12, 2024
Merged

109 update the database when an event occurs on the fs #119

merged 19 commits into from
Feb 12, 2024

Conversation

majent4
Copy link
Contributor

@majent4 majent4 commented Feb 9, 2024 •
edited
Loading

I had to move some logic in file_info mod:

  • hash compute
  • path canonicalization

And create a new function that serialize a FileInfo object.

Create and remove events are handled, modify event will be implemented in the future, I face some issues on macOS.

majent4 and others added 16 commits February 5, 2024 23:31
@majent4
lister: use canonicalize path entries
9ffe6d2
@majent4
watcher: remove file in database when event occurs
7f5f6e3
@majent4
Merge branch '111-canonicalize-filepaths-in-database' into 109-update…
2550854 
…-the-database-when-an-event-occurs-on-the-fs
@majent4
watcher: canonicalize watched directories paths
9a91260
@majent4
my-files: prepend cwd to tests dir
0da9c58
@majent4
Merge branch 'main' into 111-canonicalize-filepaths-in-database
2c4b1ec
@Cavonstavant
MyFiles(tests): Change base test dir pathbuf construction using iter …
1862814 
…+ collect
@Cavonstavant
FileLister: platform based canon path
9e9e6ab
@Cavonstavant
FileLister: Convert Path into PathBuf
870ceff
@Cavonstavant
FileLister: use as_ref.into for fix canon path
1e48cfb
@majent4
Merge branch 'main' into 111-canonicalize-filepaths-in-database
fa6d619
@majent4
Merge branch 'main' into 109-update-the-database-when-an-event-occurs…
e36b12f 
…-on-the-fs
@majent4
lib: move file lister and events handlerto proper functions
05b1d86
@majent4
Merge branch '111-canonicalize-filepaths-in-database' into 109-update…
39f27c6 
…-the-database-when-an-event-occurs-on-the-fs
@majent4
file-info: move file metadata logic into mod (#109)
7985f3c
@majent4
file-watcher: add file to db on create event (#109)
0bb2602
@majent4 majent4 marked this pull request as ready for review February 11, 2024 13:04
Cavonstavant
Cavonstavant requested changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@Cavonstavant Cavonstavant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes needed, everything else is good !

src/file_info.rs Outdated Show resolved Hide resolved
src/file_info.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@Cavonstavant Cavonstavant added enhancement New feature or request pre-beta Pre beta related issues & features labels Feb 12, 2024
Bootoyka
Bootoyka approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@Bootoyka Bootoyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Bootoyka Bootoyka merged commit 49c5213 into main Feb 12, 2024
3 checks passed
majent4 added a commit that referenced this pull request Feb 24, 2024
@majent4
watcher: get modify event kind (#119)
7cf4ade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cavonstavant Cavonstavant Cavonstavant approved these changes

@Bootoyka Bootoyka Bootoyka approved these changes

Assignees

@majent4 majent4

Labels
enhancement New feature or request pre-beta Pre beta related issues & features
Projects
tidybee-agent
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majent4 @Cavonstavant @Bootoyka