Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: add msi gen pipeline #163

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

actions: add msi gen pipeline #163

wants to merge 2 commits into from

Conversation

majent4
Copy link
Contributor

@majent4 majent4 commented Jun 18, 2024

No description provided.

@majent4
Copy link
Contributor Author

majent4 commented Jun 18, 2024

@Blynqs & @Cavonstavant I need to figure out the git event that triggers the action and the artifact filename. Please review and leave some comment if needed

Copy link
Contributor

@Cavonstavant Cavonstavant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on:
push:
tags:
- "v*"

this this the trigger that you are looking for. Maybe it could be interesting to call the Generate MSI workflow from the Release workflow. What do you think ?

@majent4
Copy link
Contributor Author

majent4 commented Jun 18, 2024

You mean embed the msi action in the release script? If yes, I agree @Cavonstavant

@Cavonstavant
Copy link
Contributor

You mean embed the msi action in the release script? If yes, I agree @Cavonstavant

@majent4, yes or change the msi workflow as a composite workflow so it can be directly used in the main release wf

Ref.: https://docs.github.com/en/actions/creating-actions/creating-a-composite-action

@Cavonstavant Cavonstavant changed the base branch from main to dev June 25, 2024 17:11
@Cavonstavant Cavonstavant changed the base branch from dev to main June 25, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants