Feature/89 renew session token #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kahlstrm
force-pushed
the
feature/89-renew-session-token
branch
from
16e12ef
to
f8a563b
Compare
PurkkaKoodari
requested changes
May 25, 2023
packages/ilmomasiina-frontend/src/modules/adminEvents/actions.ts
Outdated
Show resolved
Hide resolved
kahlstrm
force-pushed
the
feature/89-renew-session-token
branch
from
4790c73
to
290edb8
Compare
PurkkaKoodari
requested changes
May 30, 2023
Comment on lines
49
to
51
| if (!sessionResponse) { | ||
| throw Error('Bad response'); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!sessionResponse) { | |
| throw Error('Bad response'); | |
| } |
| @@ -66,5 +62,5 @@ export default async function apiFetch(uri: string, { | |||
| if (!response.ok) { | |||
| throw await ApiError.fromResponse(response); | |||
| } | |||
| return response.status === 204 ? null : response.json(); | |||
| return response.status === 204 ? null : response.json() as T; | |||
There was a problem hiding this comment.
Suggested change
| return response.status === 204 ? null : response.json() as T; | |
| return (response.status === 204 ? null : response.json()) as T; |
Comment on lines
329
to
328
| // an API endpoint for session token renewal as variant of adminLoginSchema | ||
|
|
||
| server.post( |
There was a problem hiding this comment.
Suggested change
| // an API endpoint for session token renewal as variant of adminLoginSchema | |
| server.post( | |
| server.post( |
PurkkaKoodari
force-pushed
the
feature/89-renew-session-token
branch
from
4347952
to
ba4ff29
Compare
PurkkaKoodari
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored auth typing in frontend and had it refresh the token using the already existing but not yet mapped to a route endpoint. Functionality is the following:
If the admin has logged and tries to reach an admin endpoint, the code checks the expiry time of the access token. If access token is expiring in less than 4 minutes, request a new access token from the endpoint.
Closes #89