Stop splitting strings by magic semicolons #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PurkkaKoodari
force-pushed
the
fix/answer-semicolons
branch
from
a9859e9
to
d520232
Compare
PurkkaKoodari
force-pushed
the
fix/answer-semicolons
branch
from
d520232
to
2f1c15c
Compare
joonatanaatos
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92. The app now natively handles answer options and multiple checkbox answers as arrays, instead of splitting strings by semicolon.
The migration for this does a best effort translation of the data in the DB. I don't think we can do much better. Importantly, the previous implementation made no difference between "selected empty option" and "selected no options" – the migration guesses the latter.
Along the way, I added transactions to the migration system and disabled Ajv type coercion. (Coercion was breaking
anyOfunions, and I really don't think we'll need it anywhere. I guess we'll see...)