Rewrite editor using react-final-form #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PurkkaKoodari
force-pushed
the
fix/editor-perf
branch
from
1498c9f
to
ed6a2ba
Compare
PurkkaKoodari
force-pushed
the
fix/editor-perf
branch
from
ed6a2ba
to
d3a4572
Compare
PurkkaKoodari
force-pushed
the
fix/editor-perf
branch
from
d3a4572
to
e295c50
Compare
PurkkaKoodari
force-pushed
the
fix/answer-semicolons
branch
from
a9859e9
to
d520232
Compare
PurkkaKoodari
force-pushed
the
fix/editor-perf
branch
from
e295c50
to
9d3d319
Compare
PurkkaKoodari
force-pushed
the
fix/editor-perf
branch
from
9d3d319
to
e4333d0
Compare
PurkkaKoodari
force-pushed
the
fix/answer-semicolons
branch
from
d520232
to
2f1c15c
Compare
PurkkaKoodari
force-pushed
the
fix/editor-perf
branch
from
e4333d0
to
54f4a70
Compare
joonatanaatos
approved these changes
Jan 18, 2024
packages/ilmomasiina-frontend/src/routes/Editor/components/EditorTabHeader.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #25. The editor is currently egregiously slow. This is due to two things:
useCallback& friends anywhere, just functions)This PR rewrites the editor with React Final Form. It basically eliminates most unnecessary rerendering of the forms and speeds up rerenders by like 30x when editing fields.
Some other library might've also worked, but Final Form seems to be written from the ground up so that it avoids unnecessary data dependencies.