fix open quotas bugging UI like hell when there are many events #126
Conversation
| @@ -26,7 +26,7 @@ export function useEventListState({ category }: EventListProps = {}) { | |||
| }, [category]); | |||
|
|
|||
| return useShallowMemo<State>({ | |||
| events: fetchEvents.result, | |||
| events: fetchEvents.result ?? [], | |||
There was a problem hiding this comment.
This will neutralize the entire point of the useShallowMemo as it will invalidate every time. Move the [] to a global constant to keep the reference stable.
(Or just return undefined here as before, and handle this within the useMemo later)
There was a problem hiding this comment.
What does this useShallowMemo even try to achieve here if we are using useMemo anyway?
There was a problem hiding this comment.
It ensures the caller gets a stable reference (as ilmomasiina-modules is public interface). Probably not necessary, true. (Still, this particular combination is worse than either option)
There was a problem hiding this comment.
Actually, why that exists: so that the context isn't unnecessarily updated with the same values if the provider re-renders, forcing all context consumers to re-render (since there's no useContextWithSelector)
If there are lots of events (created 2000 for performance optimization testing), the site event list becomes quite wonky when switching between languages. This should fix that.