Fix bug frontend questions editor #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kahlstrm
added
🐛 bug
Merged
kahlstrm
force-pushed
the
chore/minor-improvements
branch
2 times, most recently
from
636ce93
to
4294315
Compare
When react-final-forma-arrays removes last element of array, it removes the field entirely. This caused a bug where removing the last question crashes the application.
kahlstrm
force-pushed
the
chore/minor-improvements
branch
from
4294315
to
749406d
Compare
joonatanaatos
approved these changes
May 18, 2024
Comment on lines
+157
to
+159
| const questionItems = fields.map((name, i) => ( | ||
| <QuestionRow key={fields.value[i].key} name={name} index={i} remove={fields.remove} /> | ||
| )); |
There was a problem hiding this comment.
This existed to prevent the sortable HOC from re-rendering every time, which was a major perf bottleneck on the editor. Now it'll recreate the children and thus rerender from scratch every time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When react-final-forma-arrays removes last element of array, it removes the field entirely. This caused a bug where removing the last question crashes the application.