Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically renew auth token #141

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Automatically renew auth token #141

merged 1 commit into from
Sep 8, 2024

Conversation

PurkkaKoodari
Copy link
Member

Automatically renews the auth token whenever logged in and having the page loaded.

Perhaps a slightly cleaner option than just extending the validity. I think 30 mins to an hour of validity might still be warranted even with this setup, perhaps not 3h.

@PurkkaKoodari PurkkaKoodari requested a review from a team August 14, 2024 20:51
@PurkkaKoodari PurkkaKoodari added 🌠 feature New feature - accepted for development 🖥️ frontend Relevant to the ilmomasiina-frontend package labels Aug 14, 2024
MikaelSiidorow
MikaelSiidorow approved these changes Sep 8, 2024
View reviewed changes
Copy link

@MikaelSiidorow MikaelSiidorow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more lost changes! Though this might still log you out if the tab goes to sleep mode, but there's no easy way around that.

Perhaps for robustness, we could also store changes locally in the future, and restore on re-login?

@PurkkaKoodari
Copy link
Member Author

Perhaps for robustness, we could also store changes locally in the future, and restore on re-login?

Feel free to create an issue!

@PurkkaKoodari PurkkaKoodari merged commit abb7b1c into dev Sep 8, 2024
3 checks passed
@PurkkaKoodari PurkkaKoodari deleted the feat/auto-renew-token branch September 8, 2024 11:12
@PurkkaKoodari PurkkaKoodari mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikaelSiidorow MikaelSiidorow MikaelSiidorow approved these changes

Assignees
No one assigned
Labels
🖥️ frontend Relevant to the ilmomasiina-frontend package 🌠 feature New feature - accepted for development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PurkkaKoodari @MikaelSiidorow