Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #783

Merged
merged 7 commits into from
Jan 11, 2025
Merged

Conversation

cgiachalis
Copy link
Contributor

This PR addresses documentation fixes only. See commit messages for details.

Thanks.

Copy link
Collaborator

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

R/Array.R Outdated Show resolved Hide resolved
@cgiachalis cgiachalis requested a review from johnkerl December 10, 2024 07:33
Copy link
Collaborator

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@cgiachalis cgiachalis force-pushed the cg/documentation_fixes branch from 80b2709 to cadc20e Compare January 11, 2025 10:17
@cgiachalis
Copy link
Contributor Author

The branch now is rebased.

@johnkerl
Copy link
Collaborator

Oh @cgiachalis I see you were waiting for me to merge -- my apologies!! 🙏

@johnkerl johnkerl merged commit e07151c into TileDB-Inc:main Jan 11, 2025
6 checks passed
@cgiachalis
Copy link
Contributor Author

No, no. Didn't want the branch to diverge too much and to keep linear history. Actually, it worked well keeping it unmerged as I could add more nits. I had some small fixes jotted down and commited locally but forgot to push after rebasing. That's OK, I could do at some other time.

Thanks for merging!

@johnkerl
Copy link
Collaborator

@cgiachalis all good! Next time I'll do a better job of confirming. Thanks for all the contributions, and I'm happy to see more such! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants