Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build System Rework #781

Open
wants to merge 192 commits into
base: main
Choose a base branch
from
Open

Build System Rework #781

wants to merge 192 commits into from

Conversation

dudoslav
Copy link
Contributor

@dudoslav dudoslav commented Oct 17, 2024

This PR reworks the build system in order to properly build and package TileDB-VCF for all platforms (Linux, MacOS) and all package managers (PyPI and Conda).

The main goals of this PR:

  • Divide build into TileDB-VCF and TileDB-VCF-Py
  • TileDB-VCF needs to build as shared object and as a static library
  • TileDB-VCF needs to internally link with shared libraries or static libraries (fmt, spdlog, cli11)
  • TileDB-VCF-Py needs to properly package for PyPI, currently statically linked wheel
  • TileDB-VCF-Py conda packaging logic, only build TileDB-VCF-Py and dynamically link to TileDB-VCF (that also uses shared libs)

Windows build and package does not work yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new scikit-build-core setup copies external shared objects into Python wheel
3 participants