More robust non-empty buffer check during ingestion #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspowley
force-pushed
the
gspowley/sc-60168/non-empty-buffer-check
branch
from
77dd7b1 to
d0a515b
Compare
|
This PR needs #783 to enable macos runners. |
leipzig
approved these changes
Dec 5, 2024
spencerseale
approved these changes
Dec 5, 2024
gspowley
force-pushed
the
gspowley/sc-60168/non-empty-buffer-check
branch
from
d0a515b to
168be1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During VCF ingestion, explicitly check that the query buffers are non-empty using
utils::query_buffers_setbefore clearing the buffers.