fix(lint): satisfy new Rust 1.97 clippy lint (unbreak CI)#119
Merged
Conversation
Rust 1.97.0 (2026-07-07) landed on CI runners and its clippy flags the
pre-existing `for (_name, svc) in app.services.iter_mut()` in
appcipe-normalize ("you seem to want to iterate on a map's values"); with
-D warnings this broke every CI job on main. Switch to `values_mut()`.
Verified on the same toolchain locally (rustc 1.97.0): full-workspace
`clippy --all-targets -- -D warnings` clean, all test suites green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.97.0 (released 2026-07-07) rolled onto the CI runners and its clippy flags pre-existing code in
appcipe-normalize(for (_name, svc) in map.iter_mut()→ "you seem to want to iterate on a map's values"); with-D warningsthis fails every CI job regardless of PR content. One-line fix tovalues_mut().Verified locally on the same toolchain (rustc 1.97.0): full-workspace
cargo clippy --all-targets -- -D warningsclean,cargo fmt --checkclean, all workspace test suites green.Context/honesty: PR #118 was merged while these toolchain-drift failures were red (my mistake — the merge should have waited); #118's own code was not the cause (its Swift job passed and the clippy hit is in a crate it never touched), and this PR restores a green main.
🤖 Generated with Claude Code