-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support deep_planning_clone class decorator #1271
base: main
Are you sure you want to change the base?
Conversation
bef4b6a
to
e13b83c
Compare
Thank you for your contribution, @luxaritas! We are a bit short-handed at the moment, with many people already taking their year-end holidays. I'm going to leave this one open until my colleague, who owns the Python part of the codebase, comes back in early January and does a code review. Please be patient - we have every intention to merge this PR. |
On a general note though:
This issue also happens on Python 3.11 and 3.12. (We do not yet support 3.13.)
|
Completely understand folks being out - I have my own local adjustments for my PRs so no big deal for me anyways! I caught the CI failure after I'd already stepped away - copy-paste error. Will look into tests as well. |
Quality Gate passedIssues Measures |
This brings parity with the Java version (I also found that DeepPlanningClone did not work on a planning solution ProblemFactCollectionProperty, whereas marking the entire class to deep clone does)