better support for stages #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DannyDouglass
commented
Jan 4, 2020
scripts/deploy.sh
Outdated
| @@ -20,5 +20,5 @@ source ./config.sh | |||
|
|
|||
| OUTPUT_TEMPLATE_FILE="$PROJECT_ROOT/serverless-output.yml" | |||
| aws s3 mb "s3://$BUCKET_NAME" --region "$REGION" || true | |||
| sam deploy --region "$REGION" --template-file "$OUTPUT_TEMPLATE_FILE" --stack-name "$STACK_NAME" --parameter-overrides GitHubClientIdParameter="$GITHUB_CLIENT_ID" GitHubClientSecretParameter="$GITHUB_CLIENT_SECRET" CognitoRedirectUriParameter="$COGNITO_REDIRECT_URI" StageNameParameter="$STAGE_NAME" --capabilities CAPABILITY_IAM | |||
There was a problem hiding this comment.
pass in the stage
DannyDouglass
commented
Jan 4, 2020
| Type: AWS::Serverless::Api | ||
| Properties: | ||
| StageName: !Ref StageNameParameter | ||
| OpenApiVersion: "2.0" |
There was a problem hiding this comment.
needed to get around the sam stage bug: aws/serverless-application-model#191
|
Thanks very much for this! I especially appreciate the documentation updates 🙏 |
|
happy to help @TimothyJones! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TimothyJones not sure what the process is here, but this pr introduces an intentional api gateway that allows us to target custom stages and not generate a random stage named
Stage. these changes are deployed in a development environment and tested against that with success (minus github 2fa users as discussed in #24).