Added color blocks and Debian logo, fixed memory reporting issue. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e with current memory use reporting incorrectly.
Titaniumtown
reviewed
Jan 1, 2025
__pycache__/logos.cpython-312.pyc
Outdated
There was a problem hiding this comment.
add pycache to your .gitignore
There was a problem hiding this comment.
I deleted the pycache directory and added pycache to my .gitignore file. I'll update my pull request.
|
I'll test this later, but the code looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added basic color blocks to the bottom of the system stats, similar to other fetch programs. I'm not sure yet how Neofetch and similar utilities get the different shades, but once I figure that out, I'll try to put those in.
I also added a preliminary Debian logo, more as a test than anything. I'm still trying to get the scaling optimal, but for now, it displays correctly. I haven't integrated it into the OS detection code yet.
I also noticed that on my Linux system, the memory was not reporting correctly. The data was being grabbed from the wrong line in the /proc/meminfo for the active memory usage calculation. I fixed it so now it shows the current amount of memory used.
I am a very junior Python developer, so hopefully my code isn't too terrible. Please let me know if there are better ways to do any of this, and of course feel free to correct anything I've done!
Thanks!