forked from duckdb/duckdb
-
Notifications
You must be signed in to change notification settings - Fork 2
Support left join reordering #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Tmonster
wants to merge
23
commits into
main
Choose a base branch
from
support_left_join_reordering
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s needs to be fixed
…f left joins and cannot act as an inner join filter
…t inverted for the nofail test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for left join reordering to the join order optimizer.
This PR includes the following pieces of logic
(Select * from (select * from t1, t2) left join (select * from t3, t4) on (a = d))
have projections above the left and right subqueries. Currently, the Join Order Optimizer treats Projections as stand along relations and optimizes the children in isolation of the rest of the plan. In cases like this however, the projection is not necessary and is only added as a part of the process to plan a subquery.I've investigated the regression on the realnest benchmark and I don't think it's a huge issue. The benchmark performs a number of left joins on rowid, which is not the best way to join many nested tables. In addition, the realnest benchmark is mostly to test our performance of nested data structures, I think tpcds/tpch are better indicators of our performance of reordering left joins.
I ran tpcds on this branch at sf100 and two queries that stood out were q40 and q80