-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solving build problems and english language #19
base: master
Are you sure you want to change the base?
Conversation
libcurl for xcsoar, libxml and libxslt for lxml
seems a reasonable approach indeed. the issue remains of the mixed english/germand text on the hosted version though. could this be because of these defaults handling? |
tried again: ubuntu chrome and firefox. it is not working without the en.json file. |
my guess is indeed that in these cases german strings were used as the original strings which is obviously wrong. if that is not the case then there must be a problem somewhere else but I'm reasonably certain by now that the FYI other translation tools use IDs instead of translatable strings and in these cases you will need a dedicated ID-to-English conversion. gettext however is not using IDs so we shouldn't need it here. @TobiasLohner any comments on this? |
what's the downside of creating an en.json file? i understand that it is undesirable to create an extra en.po file, but it is possible to create the en.json file from the messages.pot file:
|
the downside is that more information has to be downloaded by the client's browser and in this case it is unnecessary because all the information already exists |
But this is already the case for all other languages right? |
with the exception that for those it is necessary 😉 |
That looks very nice @TobiasLohner! Will it also be possible to upload a cup file? |
No link tag is inserted if 'en' is preferred locale. related to TobiasLohner#18 and TobiasLohner#19
There were some steps missing in the build process and some errors:
These are fixed with these commits