Feat!: Skip model evaluation if upstream external model(s) have not changed #5277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izeigerman
reviewed
Sep 2, 2025
| @@ -690,6 +694,12 @@ def hydrate_with_intervals_by_version( | |||
| ) | |||
| for interval in snapshot_intervals: | |||
| snapshot.merge_intervals(interval) | |||
|
|
|||
| if interval.last_altered_ts: | |||
There was a problem hiding this comment.
I don't think this is correct. I don't see us distinguishing between dev and non-dev intervals. For example, adding an interval for a dev table should not have impact on last_altered_ts used for the non-dev / prod table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables SQLMesh to skip re-evaluating models that depend on external model(s) which have not been updated since the last run.
This is done by:
last_altered_tsfield in the_intervalstable which tracks the last modification to the physical table of that snapshotINFORMATION_SCHEMAfor the external model's "last altered" timestamp wherever applicable (BQ & Snowflake for the time being)