feat: add dedicated incremental_by_time_range strategy
#5306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eakmanrq
force-pushed
the
eakmanrq/dbt_add_incremental_by_time_range_strategy
branch
from
feaf7e5 to
b477bcd
Compare
izeigerman
reviewed
Sep 5, 2025
sqlmesh/dbt/model.py
Outdated
| f"Supported strategies include {collection_to_str(INCREMENTAL_BY_TIME_RANGE_STRATEGIES)}." | ||
| ) | ||
|
|
||
| if self.time_column and strategy not in {"incremental_by_time_range", "microbatch"}: |
There was a problem hiding this comment.
Why do we include microbatch here?
eakmanrq
force-pushed
the
eakmanrq/dbt_add_incremental_by_time_range_strategy
branch
from
db580fc to
af1b4f1
Compare
eakmanrq
force-pushed
the
eakmanrq/dbt_add_incremental_by_time_range_strategy
branch
from
af1b4f1 to
c7e551f
Compare
izeigerman
approved these changes
Sep 5, 2025
eakmanrq
deleted the
eakmanrq/dbt_add_incremental_by_time_range_strategy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, users could opt-in to using the incremental by time range SQLMesh behavior by adding a
time_columnproperty to their incremental config and then setting{% if sqlmesh_incremental is defined %}jinja block.This PR deprecates this behavior (but still supports it for now) and add a new incremental strategy called
incremental_by_time_range. This gives SQLMesh it's own API for defining it's specific fields and removes the need for defining a jinja code block to activate it.