Skip to content

Conversation

treysp
Copy link
Contributor

@treysp treysp commented Sep 6, 2025

@treysp treysp requested a review from crericha September 6, 2025 01:16
@@ -545,6 +545,7 @@ def create_builtin_globals(

builtin_globals["run_started_at"] = jinja_globals.get("execution_dt") or now()
builtin_globals["dbt"] = AttributeDict(builtin_globals)
builtin_globals["context"] = AttributeDict(builtin_globals)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we need another instance of the same dict. Can we do

builtin_globals["context"] = builtin_globals["dbt"]

or define a variable and share between the 2?

Copy link
Member

@izeigerman izeigerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, LGTM otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants