Skip to content

Conversation

izeigerman
Copy link
Member

No description provided.

@izeigerman izeigerman requested review from a team and Copilot September 19, 2025 03:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where seed models were incorrectly included in schema migration logic for production deployments. The change exempts seed models from migration by adding an additional condition to check if the model is a seed type.

  • Added logic to exclude seed models from production schema migration support
  • Added comprehensive integration test to verify seed model promotion behavior

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
sqlmesh/core/snapshot/definition.py Added condition to exempt seed models from schema migration support
tests/core/test_integration.py Added integration test for seed model promotion from dev to prod

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@izeigerman izeigerman merged commit af3a16f into main Sep 19, 2025
36 checks passed
@izeigerman izeigerman deleted the fix-exempt-seed-models-from-migration branch September 19, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants