Skip to content

Fix: Adapt test to use thread specific consoles #5414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

Fix: Adapt test to use thread specific consoles #5414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions tests/core/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@
import pytest
from pytest import MonkeyPatch
from pathlib import Path
from sqlmesh.core.console import set_console, get_console, TerminalConsole, CaptureTerminalConsole
from sqlmesh.core.console import (
MarkdownConsole,
set_console,
get_console,
TerminalConsole,
CaptureTerminalConsole,
)
from sqlmesh.core.config.naming import NameInferenceConfig
from sqlmesh.core.model.common import ParsableSql
from sqlmesh.utils.concurrency import NodeExecutionFailedError
Expand Down Expand Up @@ -10589,9 +10595,16 @@ def entrypoint(evaluator: MacroEvaluator) -> str:
new_model_a_snapshot_id = list(plan.modified_snapshots)[0]

# now, trigger a prod restatement plan in a different thread and block it to simulate a long restatement
thread_console = None

def _run_restatement_plan(tmp_path: Path, config: Config, q: queue.Queue):
nonlocal thread_console
q.put("thread_started")

# Give this thread its own markdown console to avoid Rich LiveError
thread_console = MarkdownConsole()
set_console(thread_console)

# give this thread its own Context object to prevent segfaulting the Python interpreter
restatement_ctx = Context(paths=[tmp_path], config=config)

Expand Down Expand Up @@ -10647,7 +10660,7 @@ def _run_restatement_plan(tmp_path: Path, config: Config, q: queue.Queue):
assert isinstance(plan_error, ConflictingPlanError)
assert "please re-apply your plan" in repr(plan_error).lower()

output = " ".join(re.split("\s+", console.captured_output, flags=re.UNICODE))
output = " ".join(re.split("\\s+", thread_console.captured_output, flags=re.UNICODE)) # type: ignore
assert (
f"The following models had new versions deployed while data was being restated: └── test.model_a"
in output
Expand Down