Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove insertbatch in statestore plugin #103

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Remove insertbatch in statestore plugin #103

merged 1 commit into from
Dec 17, 2024

Conversation

sdil
Copy link
Collaborator

@sdil sdil commented Dec 17, 2024 •
edited
Loading

Summary

From my understanding, we're not inserting the data to postgres in batch, hence this is kinda dead code. So I reckon we can remove insertBatchSize property in DurableStore

@sdil sdil requested a review from Tochemey December 17, 2024 04:48
Tochemey
Tochemey approved these changes Dec 17, 2024
View reviewed changes
Copy link
Owner

@Tochemey Tochemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch

@Tochemey Tochemey merged commit 7574335 into Tochemey:main Dec 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tochemey Tochemey Tochemey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdil @Tochemey