Use upsert statement when inserting to postgres state store #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Warning
I'm not 100% sure if this implementation is accurate and produce the same result as previous one
When I was trying the Postgres state store, my test application was stuck after creating less than 10 actors. After figuring out the bottleneck, it seems like the DELETE statement is causing the PostgreSQL to be slow.
My initial thought is, DELETE statement is there to ensure that there's only 1 row for each actor exists in the database. Please correct me if I'm wrong.
I swapped the
DELETE
SQL statement to useINSERT .... ON CONFLICT
SQL. Unfortunately, Squirrel does not support "ON CONFLUCT" statement correctly (refer Masterminds/squirrel#83 (comment)) so I have to use.Suffix
method to manually construct the statement.After changing this implementation, my test application was running fine creating 1,000 actors