feat: Add username/password SOCKS5 auth #1683
+457
−88
Open
Mergeable / Mergeable
succeeded
Feb 10, 2025 in 0s
3 checks passed!
Status: PASS
Details
✔️ Validator: TITLE
- ✔️ All the requisite validations passed for 'or' option
Input : feat: Add username/password SOCKS5 auth
Settings :{"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}
✔️ Validator: COMMIT
- ✔️ Your commit messages met the specified criteria
Input : test: Add user/password authenticated SOCKS5 proxy test,feat: Add username/password SOCKS5 auth
Settings :{"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}
✔️ Validator: DESCRIPTION
- ✔️ description must exclude '\[ \]'
Input : Fixes #1682
Not tested. Can someone with a SOCKS5 proxy with username/password test this?
I'm not sure how to prevent APIDSL from generating tox_options_set_proxy_socks5_username_length()
and tox_options_set_proxy_socks5_password_length()
function declarations. Those seem pointless as the user already sets the length in tox_options_set_proxy_socks5_username()
and tox_options_set_proxy_socks5_password()
. Savedata has the same issue with a pointless tox_options_set_savedata_length()
.
Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}
Loading