Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Tox network profiler #1885

Merged
merged 4 commits into from
Jan 15, 2025
Merged

feat: Implement Tox network profiler #1885

merged 4 commits into from
Jan 15, 2025

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Jan 14, 2022 •
edited by iphydf
Loading

This change is Reviewable

@JFreegman JFreegman added the enhancement New feature for the user, not a new feature for build script label Jan 14, 2022
@JFreegman JFreegman added this to the v0.2.x milestone Jan 14, 2022
@restyled-io restyled-io bot mentioned this pull request Jan 14, 2022
Closed
@JFreegman JFreegman force-pushed the netprof branch 11 times, most recently from b93009f to 75fd324 Compare January 14, 2022 20:13
iphydf
iphydf requested changes Jan 14, 2022
View reviewed changes
toxcore/net_profile.c Outdated Show resolved Hide resolved
toxcore/net_profile.c Show resolved Hide resolved
toxcore/net_profile.h Outdated Show resolved Hide resolved
toxcore/net_profile.h Show resolved Hide resolved
toxcore/TCP_client.h Outdated Show resolved Hide resolved
toxcore/tox_private.h Show resolved Hide resolved
toxcore/tox_private.h Outdated Show resolved Hide resolved
@JFreegman JFreegman force-pushed the netprof branch 7 times, most recently from 84ab794 to 687d5b5 Compare January 15, 2022 00:07
@codecov
Copy link

codecov bot commented Jan 15, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 48.73418% with 162 lines in your changes missing coverage. Please review.

Project coverage is 72.21%. Comparing base (0b45eab) to head (aa64916).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
toxcore/tox_api.c 0.00% 102 Missing ⚠️
toxcore/tox_private.c 57.40% 46 Missing ⚠️
toxcore/TCP_server.c 64.28% 5 Missing ⚠️
toxcore/net_profile.c 92.00% 4 Missing ⚠️
toxcore/TCP_connection.c 84.61% 2 Missing ⚠️
toxcore/net_crypto.c 66.66% 2 Missing ⚠️
toxcore/network.c 93.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1885      +/-   ##
==========================================
- Coverage   72.69%   72.21%   -0.49%     
==========================================
  Files         150      151       +1     
  Lines       30780    31122     +342     
==========================================
+ Hits        22377    22476      +99     
- Misses       8403     8646     +243

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iphydf
iphydf approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 19 files at r1, 8 of 9 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @JFreegman)

toxcore/tox_private.h, line 60 at r1 (raw file):

Previously, JFreegman wrote…

The reason I named it ZERO is because it has a different purpose depending on the packet type (see the above comment). Any suggestions?

Ok, that's fine then.

@pull-request-attention pull-request-attention bot assigned JFreegman and unassigned iphydf Jan 15, 2022
iphydf
iphydf reviewed Jan 15, 2022
View reviewed changes
Copy link
Member

@iphydf iphydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 19 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @JFreegman)

@iphydf iphydf modified the milestones: v0.2.21, v0.2.22 Jan 14, 2025
@JFreegman JFreegman modified the milestones: v0.2.22, v0.2.21 Jan 15, 2025
@Green-Sky Green-Sky mentioned this pull request Jan 15, 2025
Open
@JFreegman JFreegman removed the request for review from robinlinden January 15, 2025 19:16
@JFreegman JFreegman modified the milestones: v0.2.22, v0.2.21 Jan 15, 2025
@JFreegman
chore: Add code for future netprof TCP testing
aa64916 
TCP does not presently work for autotests, but this
will allow us to test netprof with TCP packets
when it's fixed
@iphydf iphydf self-requested a review January 15, 2025 19:41
@JFreegman JFreegman merged commit aa64916 into TokTok:master Jan 15, 2025
65 of 66 checks passed
@JFreegman JFreegman deleted the netprof branch January 15, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iphydf iphydf iphydf approved these changes

@robinlinden robinlinden robinlinden approved these changes

@Green-Sky Green-Sky Green-Sky approved these changes

Assignees

@JFreegman JFreegman

Labels
enhancement New feature for the user, not a new feature for build script
Projects
None yet
Milestone
v0.2.21
Development

Successfully merging this pull request may close these issues.
4 participants
@JFreegman @Green-Sky @robinlinden @iphydf