Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move some OS-specifics into tox_system. #2397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 29, 2023

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Attention: Patch coverage is 77.31844% with 203 lines in your changes are missing coverage. Please review.

Project coverage is 72.44%. Comparing base (102a1fa) to head (a3fc637).

❗ Current head a3fc637 differs from pull request most recent head 09f77d8. Consider uploading reports for the commit 09f77d8 to get more accurate results

Files Patch % Lines
toxcore/group_chats.c 74.24% 34 Missing ⚠️
toxcore/network_test_util.cc 0.00% 18 Missing ⚠️
toxcore/tox_system.c 0.00% 17 Missing ⚠️
testing/fuzzing/fuzz_support.cc 40.00% 12 Missing ⚠️
toxcore/os_network.c 79.31% 12 Missing ⚠️
toxcore/tox_network.c 52.00% 12 Missing ⚠️
toxcore/tox_log.c 0.00% 11 Missing ⚠️
toxcore/group_connection.c 83.33% 10 Missing ⚠️
toxcore/os_time.c 9.09% 10 Missing ⚠️
toxcore/tox.c 47.36% 10 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
- Coverage   73.08%   72.44%   -0.64%     
==========================================
  Files         149      162      +13     
  Lines       30531    30712     +181     
==========================================
- Hits        22313    22250      -63     
- Misses       8218     8462     +244     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf modified the milestones: v0.2.20, v0.2.19 Aug 31, 2023
@iphydf iphydf force-pushed the system branch 7 times, most recently from da5c78f to c0482cc Compare November 15, 2024 00:00
@iphydf iphydf force-pushed the system branch 9 times, most recently from b473a48 to 66b1a2f Compare December 2, 2024 10:45
@iphydf iphydf force-pushed the system branch 2 times, most recently from aff717f to f42f5c4 Compare December 29, 2024 11:13
@iphydf iphydf force-pushed the system branch 2 times, most recently from 256f829 to c4d3019 Compare January 4, 2025 21:55
@iphydf iphydf force-pushed the system branch 2 times, most recently from fddf203 to db19e46 Compare January 13, 2025 16:06
@iphydf iphydf modified the milestones: v0.2.21, v0.2.22 Jan 14, 2025
@iphydf iphydf force-pushed the system branch 4 times, most recently from 89207ec to 787de0e Compare January 15, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring production code, eg. renaming a variable, not affecting semantics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant