Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove kicked peers from saved peers list #2738

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup: remove kicked peers from saved peers list #2738

wants to merge 1 commit into from
+25 −5

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Mar 13, 2024 •
edited by iphydf
Loading

This change is Reviewable

@JFreegman JFreegman added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Mar 13, 2024
@JFreegman JFreegman added this to the v0.2.20 milestone Mar 13, 2024
@JFreegman JFreegman force-pushed the ngc_dont_save_kicked_peers branch 4 times, most recently from dbc7be6 to 16fa212 Compare March 13, 2024 14:45
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.97%. Comparing base (fa723e3) to head (b6be945).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
toxcore/group_chats.c 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2738      +/-   ##
==========================================
+ Coverage   72.96%   72.97%   +0.01%     
==========================================
  Files         149      149              
  Lines       30566    30577      +11     
==========================================
+ Hits        22303    22315      +12     
+ Misses       8263     8262       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JFreegman JFreegman marked this pull request as draft March 13, 2024 16:11
@JFreegman JFreegman marked this pull request as ready for review March 28, 2024 01:24
@JFreegman JFreegman force-pushed the ngc_dont_save_kicked_peers branch from 16fa212 to 5f7e56f Compare March 28, 2024 01:51
@iphydf iphydf modified the milestones: v0.2.20, v0.2.21 Nov 6, 2024
@JFreegman JFreegman force-pushed the ngc_dont_save_kicked_peers branch from 5f7e56f to b6be945 Compare November 9, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iphydf iphydf iphydf left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@JFreegman JFreegman

Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Projects
None yet
Milestone
v0.2.21
Development

Successfully merging this pull request may close these issues.
2 participants
@JFreegman @iphydf