Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Mark events/dispatch headers as experimental. #2842

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 25, 2025

We're already installing these, but they have been experimental all this time. We should not install them until we're really done with them.


This change is Reviewable

@iphydf iphydf added this to the v0.2.21 milestone Jan 25, 2025
@iphydf iphydf marked this pull request as ready for review January 25, 2025 22:21
@github-actions github-actions bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Jan 25, 2025
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.14%. Comparing base (f276b39) to head (7c9fa37).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2842      +/-   ##
==========================================
- Coverage   72.16%   72.14%   -0.02%     
==========================================
  Files         151      152       +1     
  Lines       31136    31182      +46     
==========================================
+ Hits        22469    22496      +27     
- Misses       8667     8686      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We're already installing these, but they have been experimental all this
time. We should not install them until we're really done with them.
@iphydf iphydf force-pushed the experimental-events branch from 7c9fa37 to 8799bea Compare January 25, 2025 22:53
@toktok-releaser toktok-releaser merged commit 8799bea into TokTok:master Jan 25, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Development

Successfully merging this pull request may close these issues.

3 participants