Fix false positive on nullable public properties #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Feb 12, 2025
| public function doFoo(self $foo) | ||
| { | ||
| $x = $foo->getBar(); | ||
| echo $x->property; |
There was a problem hiding this comment.
unhandled case was here: $x is null|PublicPropertyClass, which the collector did not accept as a property fetch of PublicPropertyClass->property
|
@TomasVotruba do you have a moment to merge and release this fix? :-) |
TomasVotruba
approved these changes
Feb 14, 2025
|
Sure, thank you for improvements 🤙👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this PR a false positive was reported when a public property was used, but the code did not explicitly eliminate a possible
nullvalue from a union