Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApproximateGradientSumFunction class and example SGFunction for Stochastic Gradient Descent #1550

Merged
merged 183 commits into from
Mar 26, 2024

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Oct 25, 2023

Describe your changes

Added the ApproximateGradientSumFunction class and example SGFunction for Stochastic Gradient Descent and relevant unit tests

Describe any testing you have performed

See code

Link relevant issues

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@MargaretDuff
Copy link
Member Author

Jenkins is happy
image

@MargaretDuff MargaretDuff dismissed jakobsj’s stale review March 26, 2024 12:27

Changes made and checked with Edo

@MargaretDuff MargaretDuff merged commit 040f214 into TomographicImaging:master Mar 26, 2024
8 checks passed
@MargaretDuff MargaretDuff deleted the SGD branch March 26, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Stochastic Gradient Descent (SGD) Implement SubsetSumFunction
6 participants