-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spdhg with stochastic sampler #1644
base: master
Are you sure you want to change the base?
Spdhg with stochastic sampler #1644
Conversation
Quick docstring Signed-off-by: Margaret Duff <[email protected]>
…ate prob in spdhg
For reference:
PDHG functions:
New SPDHG parameters:
New SPDHG functions:
|
See also Gemma's comment #1496 (comment) |
Signed-off-by: Margaret Duff <[email protected]>
I am struggling with a test which compares PDHG and SPDHG where the number of subsets is one: #1863 |
Signed-off-by: Margaret Duff <[email protected]>
Signed-off-by: Margaret Duff <[email protected]>
# Gradient descent for the primal variable | ||
# x_tmp = x - tau * zbar | ||
self.x.sapyb(1., self.zbar, -self.tau, out=self.x_tmp) | ||
self.x.sapyb(1., self._zbar, -self._tau, out=self._x_tmp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if self._tau
is an array this allocates an array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think fixed so that this doesn't reallocate an array
Signed-off-by: Margaret Duff <[email protected]>
a910556
to
f8b513b
Compare
Describe your changes
Describe any testing you have performed
Please add any demo scripts to CIL-Demos/misc/
Test with SPDHG https://github.com/TomographicImaging/CIL-Demos/blob/main/misc/testing_sampling_SPDHG.ipynb
Similar results gained for all samplers for SPDHG, with 10 subsets
With 80 subsets:
Link relevant issues
Part of the stochastic work plan. Closes #1575. Closes #1576. Closes #1500. Closes #1496
Checklist when you are ready to request a review
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.