Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python and Numpy binary variants #1765

Closed

Conversation

gfardell
Copy link
Member

@gfardell gfardell commented Mar 28, 2024

Changes

Update CIL binaries to target current py and np versions. This includes update of unittests to work with py3.12 as some unittests asserts have been deprecated i.e. assertEquals and assertDictContainsSubset

Requires all plugins to be updated to the new variants and binaries to be built and hosted on anaconda/ccpi

Note:
This fails on the CIL build forcing python 3.8 with:

======================================================================
ERROR: test_get_dataset_metadata (test_io.Test_HDF5_utilities)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/CIL/CIL/Wrappers/Python/test/test_io.py", line 476, in test_get_dataset_metadata
    self.assertEqual(dset_dict, dict_by_hand | dset_dict)
TypeError: unsupported operand type(s) for |: 'dict' and 'dict'

----------------------------------------------------------------------

This is not an issue as we are dropping 3.8 support with this PR and new functionality is in py3.9.

Testing you performed

Please add any demo scripts to https://github.com/TomographicImaging/CIL-Demos/tree/main/misc

Related issues/links

closes #1719

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@gfardell gfardell marked this pull request as ready for review April 16, 2024 16:12
@casperdcl casperdcl mentioned this pull request Apr 16, 2024
9 tasks
casperdcl added a commit that referenced this pull request Apr 16, 2024
- closes #1713 bump astra
- closes #1764 bump tigre
- closes #1761 bump ccpi-regulariser
- closes #1765 bumpy python & numpy
@casperdcl casperdcl mentioned this pull request Apr 24, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ToDo
Development

Successfully merging this pull request may close these issues.

CIL v24 supported py and np versions
1 participant