Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: split & speedup datacontainer binary operations #1896

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Aug 19, 2024

  • lower tests memory requirements
    • prevents OoM crashes on my laptop
    • also speeds up tests by several seconds
  • split into separate test functions
  • cleanup/reintroduce timing logic
  • misc tidy

👉 diff sans whitespace

Copy link
Member

@MargaretDuff MargaretDuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also get rid of the timing steps used for the commented out test on new line 207, 227, 340?

Otherwise looks like simple changes that don't affect the tests but make them quicker and clearer

Wrappers/Python/test/test_DataContainer.py Outdated Show resolved Hide resolved
Wrappers/Python/test/test_DataContainer.py Outdated Show resolved Hide resolved
@casperdcl casperdcl enabled auto-merge (squash) August 21, 2024 09:01
Copy link
Member

@MargaretDuff MargaretDuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @casperdcl

@casperdcl casperdcl merged commit 084063b into master Aug 21, 2024
7 checks passed
@casperdcl casperdcl deleted the test-speedup branch August 21, 2024 12:10
@gfardell gfardell added this to the v24.2.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants