Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "find_package(Python) (#1842)" #1899

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Revert "find_package(Python) (#1842)" #1899

merged 1 commit into from
Aug 21, 2024

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Aug 21, 2024 •
edited
Loading

This reverts commit c87b61e, reversing changes made to f25b198.

Apparently Jenkins CI was failing? Nobody knows why.

@casperdcl
Revert "find_package(Python) (#1842)"
cd8d426 
This reverts commit c87b61e, reversing
changes made to f25b198.
@casperdcl casperdcl self-assigned this Aug 21, 2024
@casperdcl casperdcl added bug Something isn't working Merge pending jenkins Once jenkins is happy with can be merged Waiting for review labels Aug 21, 2024
@gfardell
Copy link
Member

https://anvil.softeng-support.ac.uk/jenkins/job/CILsingle/job/CCPi-Framework-dev/6072/console we shall see if this is the culprit...

@gfardell gfardell self-requested a review August 21, 2024 15:44
gfardell
gfardell approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@gfardell gfardell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins passed without these commits. So let's merge this revert and troubleshoot in the PR.

@gfardell gfardell merged commit 9d7ebc4 into master Aug 21, 2024
7 checks passed
@gfardell gfardell deleted the revert-find-package branch August 21, 2024 16:30
@casperdcl casperdcl mentioned this pull request Aug 21, 2024
Closed
casperdcl added a commit that referenced this pull request Aug 29, 2024
@casperdcl
CI: GHA conda build & upload
738b7e6 
- part of #1870
- related to #1875
- related to #1899 <- #1842 <- #1835
- part of #1598
- related to #1430
- related to #1416
- related to #1205
@casperdcl casperdcl mentioned this pull request Aug 29, 2024
Merged
12 tasks
casperdcl added a commit that referenced this pull request Aug 29, 2024
@casperdcl
CI: GHA conda build & upload
366ec2c 
- part of #1870
- related to #1875
- related to #1899 <- #1842 <- #1835
- part of #1598
- related to #1430
- related to #1416
- related to #1205
casperdcl added a commit that referenced this pull request Aug 29, 2024
@casperdcl
CI: GHA conda build & upload
bf900d0 
- part of #1870
- related to #1875
- related to #1899 <- #1842 <- #1835
- part of #1598
- related to #1430
- related to #1416
- related to #1205
casperdcl added a commit that referenced this pull request Aug 30, 2024
@casperdcl
CI: GHA conda build & upload (#1914)
4ea0089 
- skip most of conda matrix on PR
- update docs (replace CI badges, describe new matrix)
- fixes #1870
- part of #1598
- part of #1560
- related to #1875
- related to #1899 <- #1842 <- #1835
- related to #1430
- related to #1416
- related to #1205
- it's my birthday and I'l merge if I wanna
casperdcl added a commit that referenced this pull request Aug 30, 2024
@casperdcl
CI: GHA conda build & upload (#1914)
d653486 
- skip most of conda matrix on PR
- update docs (replace CI badges, describe new matrix)
- fixes #1870
- part of #1598
- part of #1560
- related to #1875
- related to #1899 <- #1842 <- #1835
- related to #1430
- related to #1416
- related to #1205
- it's my birthday and I'l merge if I wanna
casperdcl added a commit that referenced this pull request Aug 30, 2024
@casperdcl
CI: GHA conda build & upload (#1914)
5afcad4 
- skip most of conda matrix on PR
- update docs (replace CI badges, describe new matrix)
- fixes #1870
- part of #1598
- part of #1560
- related to #1875
- related to #1899 <- #1842 <- #1835
- related to #1430
- related to #1416
- related to #1205
- it's my birthday and I'l merge if I wanna
casperdcl added a commit that referenced this pull request Aug 30, 2024
@casperdcl
CI: GHA conda build & upload (#1914)
a910556 
- skip most of conda matrix on PR
- update docs (replace CI badges, describe new matrix)
- fixes #1870
- part of #1598
- part of #1560
- related to #1875
- related to #1899 <- #1842 <- #1835
- related to #1430
- related to #1416
- related to #1205
- it's my birthday and I'l merge if I wanna
casperdcl added a commit that referenced this pull request Sep 2, 2024
@casperdcl
CI: GHA conda build & upload (#1914)
f8b513b 
- skip most of conda matrix on PR
- update docs (replace CI badges, describe new matrix)
- fixes #1870
- part of #1598
- part of #1560
- related to #1875
- related to #1899 <- #1842 <- #1835
- related to #1430
- related to #1416
- related to #1205
- it's my birthday and I'll merge if I wanna
casperdcl added a commit that referenced this pull request Sep 2, 2024
@casperdcl
future-proof find_package(Python) again
66528ea 
- reverts #1899
- reinstates #1842
- fixes #1835
@casperdcl casperdcl mentioned this pull request Sep 2, 2024
Merged
casperdcl added a commit that referenced this pull request Sep 13, 2024
@casperdcl
future-proof find_package(Python) again
535b384 
- reverts #1899
- reinstates #1842
- fixes #1835
casperdcl added a commit that referenced this pull request Sep 18, 2024
@casperdcl
future-proof find_package(Python) again (#1924)
a181c35 
- reverts #1899
- reinstates #1842
- fixes #1835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfardell gfardell gfardell approved these changes

@paskino paskino Awaiting requested review from paskino

Assignees

@casperdcl casperdcl

Labels
bug Something isn't working Merge pending jenkins Once jenkins is happy with can be merged Waiting for review
Projects
CIL work
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casperdcl @gfardell