Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow initial = None in SIRT #1906

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Aug 22, 2024

Changes

SIRT takes initial = None.

To maintain the order of arguments to SIRT, both operator and data have default None when the arguments are passed to the init but raise a ValueError if they are not provided.

Testing you performed

New unit test implemented

Related issues/links

Fixes #1895

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@MargaretDuff MargaretDuff self-assigned this Aug 22, 2024
Copy link
Contributor

@jakobsj jakobsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MargaretDuff
Copy link
Member Author

Jenkins is happy
image

@MargaretDuff MargaretDuff merged commit a7b0ba0 into TomographicImaging:master Aug 29, 2024
8 checks passed
@MargaretDuff MargaretDuff deleted the sirt-initial branch August 29, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIRT - documentation unclear for default values for initial
3 participants