Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output format options to the mpg123 decoder #83

Closed
wants to merge 6 commits into from

Conversation

mdluo
Copy link

@mdluo mdluo commented Jan 11, 2018

Relevant issue: #52

First call mpg123_format_none to clear the output format table, then call mpg123_format to set the output format based on the option parameter of the Decoder constructor.

Encoding table: https://github.com/TooTallNate/node-lame/blob/master/deps/mpg123/src/libmpg123/mpg123.h.in#L348-L388

mpg123_format_none: https://www.mpg123.de/api/group__mpg123__output.shtml#ga931ca238347de394901c3baa13e7a8f8

mpg123_format: https://www.mpg123.de/api/group__mpg123__output.shtml#gadad5794afc300a997e517dbe397dc2c7

Inspired by: https://sourceforge.net/p/mpg123/mailman/message/25123550/

@LinusU
Copy link
Collaborator

LinusU commented Apr 25, 2018

Ehhh 🤔 does the last commit remove the entire library?

@mdluo
Copy link
Author

mdluo commented Apr 25, 2018

@LinusU
Just forgot this PR is still open 😂. I will submit another PR later, closing this one now.

@mdluo
Copy link
Author

mdluo commented Apr 25, 2018

See: #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants