-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Add Symlink support for fuse #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for submitting, let me take a look into this and do some testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be doing testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write about the benefits of using symlinking with FUSE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the default be off?
MOUNT_REFRESH_TIME = MountRefreshTimes[MOUNT_REFRESH_TIME].value | ||
|
||
DEBUG_MODE = os.getenv("DEBUG_MODE", False) in [True,'true'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should just wrap in a bool to convert it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure it works like this, but needs testing
|
||
|
||
def create_symlink_in_symlink_path(vfs_path, symlink_path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use camelcase
get_symlink_data = getAllData('symlinks')[0] | ||
except: | ||
get_symlink_data = [] | ||
# logging.debug(f"Symlink db:\n{get_symlink_data}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeping the debug would be helpful
Add symlinking capabilities to fuse mount method
Adds new (optional) .env variable "SYMLINK_PATH" which instructs app to create a symlink to files when they are created in fuse vfs.
Replaces bug found in previous pull request #28