Skip to content

Conversation

lexiismadd
Copy link

Add symlinking capabilities to fuse mount method
Adds new (optional) .env variable "SYMLINK_PATH" which instructs app to create a symlink to files when they are created in fuse vfs.
Replaces bug found in previous pull request #28

@Wamy-Dev
Copy link
Contributor

Thanks for submitting, let me take a look into this and do some testing.

Copy link
Contributor

@Wamy-Dev Wamy-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be doing testing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write about the benefits of using symlinking with FUSE?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the default be off?

MOUNT_REFRESH_TIME = MountRefreshTimes[MOUNT_REFRESH_TIME].value

DEBUG_MODE = os.getenv("DEBUG_MODE", False) in [True,'true']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should just wrap in a bool to convert it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure it works like this, but needs testing



def create_symlink_in_symlink_path(vfs_path, symlink_path):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use camelcase

get_symlink_data = getAllData('symlinks')[0]
except:
get_symlink_data = []
# logging.debug(f"Symlink db:\n{get_symlink_data}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping the debug would be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants