Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom HTTP service SPI #7600

Merged
merged 13 commits into from
Mar 4, 2025
Merged

Custom HTTP service SPI #7600

merged 13 commits into from
Mar 4, 2025

Conversation

mgoworko
Copy link
Contributor

@mgoworko mgoworko commented Feb 27, 2025 •
edited
Loading

Describe your changes

Added SPI interface CustomHttpServiceProvider. It allows to run custom services and expose endpoints alongside Nu Designer. Added, because external clients need functionalities, that we do not want to implement in Nu. That way we provide only minimal interface providing necessary information, but the entire business logic can be on client's side.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added the docs label Feb 27, 2025
@mgoworko mgoworko marked this pull request as ready for review February 27, 2025 10:55
coutoPL
coutoPL reviewed Feb 27, 2025
View reviewed changes
@mgoworko
review changes
5c89f5b
@mgoworko
Merge remote-tracking branch 'origin/staging' into preview/custom-htt…
f4420df 
…p-service-spi

# Conflicts:
#	designer/server/src/main/scala/pl/touk/nussknacker/ui/process/repository/DBFetchingProcessRepository.scala
#	designer/server/src/main/scala/pl/touk/nussknacker/ui/server/AkkaHttpBasedRouteProvider.scala
@mgoworko
qs
1f52e6b
@mgoworko
qs
0fcdd96
@mgoworko
review changes
7b24b9a
@mgoworko
qs
4e3970c
@mgoworko mgoworko requested a review from coutoPL February 27, 2025 17:06
@mgoworko mgoworko requested a review from coutoPL March 3, 2025 13:20
coutoPL
coutoPL approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment

but in general LGTM!

@mgoworko mgoworko merged commit d0a88c8 into staging Mar 4, 2025
29 of 34 checks passed
@mgoworko mgoworko deleted the preview/custom-http-service-spi branch March 4, 2025 19:49
mgoworko added a commit that referenced this pull request Mar 4, 2025
@mgoworko
Custom HTTP service SPI (#7600)
7ed67c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coutoPL coutoPL coutoPL approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgoworko @coutoPL