Skip to content

Rename name to path in rustdoc#1708

Merged
MarcusSorealheis merged 1 commit intoTraceMachina:mainfrom
jaroeichler:fix-docs
Apr 23, 2025
Merged

Rename name to path in rustdoc#1708
MarcusSorealheis merged 1 commit intoTraceMachina:mainfrom
jaroeichler:fix-docs

Conversation

@jaroeichler
Copy link
Contributor

@jaroeichler jaroeichler commented Apr 23, 2025 •
edited
Loading

This reflects the changes in Rustdoc JSON Types in rust-lang/rust#135799. Fixes #1707.

This change is Reviewable

@jaroeichler
Copy link
Contributor Author

jaroeichler commented Apr 23, 2025

+@MarcusSorealheis

MarcusSorealheis
MarcusSorealheis approved these changes Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and all files reviewed, and pending CI: Bazel Dev / macos-15, Cargo Dev / macos-15, Coverage, Installation / macos-13, Installation / macos-15, NativeLink.com Cloud / Remote Cache / macos-15, Remote / lre-cc / large-ubuntu-22.04, Remote / lre-rs / large-ubuntu-22.04

MarcusSorealheis
MarcusSorealheis approved these changes Apr 23, 2025
View reviewed changes
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Bazel Dev / macos-15, Cargo Dev / macos-15, Coverage, Installation / macos-13, Installation / macos-15, NativeLink.com Cloud / Remote Cache / macos-15, Remote / lre-cc / large-ubuntu-22.04, Remote / lre-rs / large-ubuntu-22.04

@MarcusSorealheis MarcusSorealheis enabled auto-merge (squash) April 23, 2025 00:41
@MarcusSorealheis
Copy link
Collaborator

MarcusSorealheis commented Apr 23, 2025

Thanks for fixing

@MarcusSorealheis MarcusSorealheis merged commit 8f327d7 into TraceMachina:main Apr 23, 2025
37 checks passed
MarcusSorealheis pushed a commit to MarcusSorealheis/nativelink that referenced this pull request Nov 3, 2025
@jaroeichler
Rename name to path in rustdoc (TraceMachina#1708)
addc092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcusSorealheis MarcusSorealheis MarcusSorealheis approved these changes

Assignees

@MarcusSorealheis MarcusSorealheis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Configuration Reference down

2 participants

@jaroeichler @MarcusSorealheis