Skip to content

Comments

If all workers are fully allocated, shortcut find workers#2130

Merged
palfrey merged 1 commit intoTraceMachina:mainfrom
palfrey:fast-scheduling-with-full-workers
Feb 19, 2026
Merged

If all workers are fully allocated, shortcut find workers#2130
palfrey merged 1 commit intoTraceMachina:mainfrom
palfrey:fast-scheduling-with-full-workers

Conversation

@palfrey
Copy link
Member

@palfrey palfrey commented Feb 2, 2026

Description

We've seen cases with many workers where things slow down, and this PR should shortcut the lookup operation a bit in cases where all workers are fully loaded.

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

bazel test //...

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@palfrey palfrey marked this pull request as ready for review February 2, 2026 12:18
@amankrx
Copy link
Collaborator

amankrx commented Feb 2, 2026

/build-image

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Image built and pushed!

ghcr.io/TraceMachina/nativelink:499ff07

@MarcusSorealheis MarcusSorealheis enabled auto-merge (squash) February 4, 2026 22:03
@MarcusSorealheis
Copy link
Collaborator

@palfrey WE might want to write a blogpost about this small change

@amankrx
Copy link
Collaborator

amankrx commented Feb 5, 2026

Not sure if this issue is due to this PR, but the jobs are being allocated really slowly to the workers. Running a couple of more tests to identify the issue anyway.

@palfrey palfrey force-pushed the fast-scheduling-with-full-workers branch 2 times, most recently from b2147ee to 972ac21 Compare February 16, 2026 09:50
@palfrey palfrey disabled auto-merge February 19, 2026 11:14
@palfrey palfrey force-pushed the fast-scheduling-with-full-workers branch from 972ac21 to 9c663cb Compare February 19, 2026 11:14
@palfrey palfrey merged commit faad8bb into TraceMachina:main Feb 19, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants